fix(transformer): value => value[0] for legacyLogicalProperties to avoid duplicate !important#168
Closed
dengfuping wants to merge 1 commit intoant-design:masterfrom
Closed
Conversation
dengfuping
commented
Dec 11, 2023
| } else if (matchValue.length === 1) { | ||
| // Handle like `marginBlockStart` => `marginTop` | ||
| clone[matchValue[0]] = wrapImportantAndSkipCheck(value, important); | ||
| clone[matchValue[0]] = wrapImportantAndSkipCheck(values[0], important); |
Contributor
Author
There was a problem hiding this comment.
- should pass
split valueinstead ofraw value.
…oid duplicate !important
dengfuping
force-pushed
the
dengfuping-fix-important
branch
from
085c5d2 to
a8065bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!importantwhen enable legacyLogicalPropertiesTransformer for paddingInlineStart and marginBlockStart with !important #167.